Fix make_polycone length check to catch a single mismatched radius array#10
Merged
Merged
Conversation
The guard used `not len(iradius) == nplanes and not len(oradius) == nplanes`, i.e. (iradius wrong) AND (oradius wrong) — it only raised when BOTH arrays were wrong. The common case, exactly one array having the wrong length, slipped through and produced a malformed parameter string. Use `or` so either mismatch raises. Verified: with 3 zplanes, a single wrong array (2/3 or 3/2) now errors; matching arrays still pass (Python 3.12). Fixes gemc#4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The guard used
not len(iradius) == nplanes and not len(oradius) == nplanes— it only raised when both radius arrays were wrong. The common case (exactly one array with the wrong length) slipped through and produced a malformed parameter string. Useorso either mismatch raises.Validation: with 3 zplanes, a single wrong array (2/3 or 3/2) now errors; matching arrays still pass (Python 3.12).
Fixes #4