Remove usage of TF2_CalcIsAttackCritical entirely#218
Merged
safalin1 merged 1 commit intogemidyne:masterfrom Sep 2, 2021
Merged
Remove usage of TF2_CalcIsAttackCritical entirely#218safalin1 merged 1 commit intogemidyne:masterfrom
safalin1 merged 1 commit intogemidyne:masterfrom
Conversation
Contributor
Author
|
Unsure what version to bump to for this so I'll leave it to you. Also, looks like this should be ported to |
When any plugin uses this forward, serverside crit calculation desyncs from clientside crit calculation, even if the forward solely returns Plugin_Continue. Any time MicroTF2 is loaded, 'fake crits' start occurring on certain server setups, even if IsPluginEnabled is false. None of the minigames seem to use this forward aside from 26, which can easily be replaced by HalloweenCritCandy. If crits need to be disabled, either the attribute for 'no random crits' or the cvar for disabling crits can be used.
safalin1
added a commit
that referenced
this pull request
Sep 2, 2021
See PR #218 for more information.
Collaborator
|
Thanks for the PR - I never knew this was an issue. I'll look to doing another maintenance release tomorrow / this weekend. Ported to dev branch in de5c8cf |
Contributor
Author
|
There's a fix for mainline SourceMod ( alliedmodders/sourcemod#1573 ) for this in the works as well, but the plugin is using CalcCritical for something it really doesn't seem to need to, so I figured we can remove it and then add it back later if it's definitely needed for something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When any plugin uses this forward, serverside crit calculation desyncs from clientside crit calculation, even if the forward solely returns Plugin_Continue.
Any time MicroTF2 is loaded, 'fake crits' start occurring on certain server setups, even if IsPluginEnabled is false.
None of the minigames seem to use this forward aside from 26, which can easily be replaced by HalloweenCritCandy.
If crits need to be disabled, either the attribute for 'no random crits' or the cvar for disabling crits can be used.