When you pick an alternative at the plan-approval gate, reArchitect() builds a fresh plan and goes straight to build. planApprovalGate (run.ts) only wraps the first architect, so the re-architected plan is never approved, even though it can differ a lot from the one you rejected. Found while dogfooding #308.
Options:
- re-fire the gate around the re-architected plan too
- treat the alternative pick as implicit approval (current behavior)
Product call. I lean toward re-firing so autopilot users still get one look at the final plan.
When you pick an alternative at the plan-approval gate,
reArchitect()builds a fresh plan and goes straight to build.planApprovalGate(run.ts) only wraps the first architect, so the re-architected plan is never approved, even though it can differ a lot from the one you rejected. Found while dogfooding #308.Options:
Product call. I lean toward re-firing so autopilot users still get one look at the final plan.