feat(dashboard): New preset form as a modal dialog (#1025)#1045
Merged
Conversation
The create form was an inline panel that pushed the composer controls down when it opened. Render it in a centered modal instead, on a new reusable shadcn-style Dialog (Base UI's plain Dialog, so a backdrop click or Esc dismisses it, unlike the AlertDialog used for destructive confirms). Same fields, including the Save to scope choice.
suleimansh
marked this pull request as ready for review
July 22, 2026 19:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1044. The "New preset" create form was an inline panel that pushed the composer controls down when it opened. This renders it as a centered modal dialog instead.
What
ui/dialog.tsx— a shadcn-style dialog on Base UI's plainDialog(same library as the existingconfirm-dialog, but the non-alert variant, so a backdrop click / Esc / the ✕ dismisses it — right for a form, vs the focus-trapped no-light-dismiss AlertDialog used for destructive confirms). Themed with the sameborder-border/bg-cardtokens.PresetCreatePanelnow renders its form (name, prompt, the "Save to: Just me / This project" scope, Cancel/Save) inside that dialog. Esc handling delegated to the Dialog; ⌘/Ctrl+Enter still saves.Tests
Notes