feat(framework): support event: key in the-framework.yml (#267)#268
Merged
Conversation
Finishes the per-repo config surface: the-framework.yml can now set the
build event kind (event: bug-fix) alongside preset and modes. Precedence is
--kind flag > the-framework.yml event > preset defaultEvent > major-change,
so file-set events flow through the same runFramework({buildEvent}) path #266
added.
Threads event through parseFrameworkConfig, mergeRunConfig, and the config
narration; the no-op note now fires when any build event is set without a
preset. Help text updated.
suleimansh
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishes the per-repo config surface. #266 let a run pick its build event kind via
--kindor a preset's default, butthe-framework.yml(#258) could only set preset + modes. Now it can setevent:too:Precedence:
--kindflag >the-framework.ymlevent > preset defaultEvent >major-change. File-set events flow through the samerunFramework({buildEvent})path #266 added, so a repo pins its event kind once instead of retyping--kindeach run.Threads
eventthroughparseFrameworkConfig,mergeRunConfig, and the◆ the-framework.yml:narration; the no-op note now fires for any build event set without a preset (wording generalized from--kind X).Verified e2e with a temp workspace holding
event: bug-fix: run narrates◆ the-framework.yml: preset=software-development, event=bug-fixthenReview policy: the Software Development loop drives the bug-fix review. 122 framework tests green.Closes #267