ticket locks are the format's .lock.md claim; PENDING placeholders + 6h timer removed (fix #1420) - #1425
Merged
Merged
Conversation
…s and their 6h timer are gone (#1420) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
suleimansh
marked this pull request as ready for review
July 31, 2026 15:10
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the plan agreed on #1420 (comment): the code now speaks the same lock the prompts define, and the old mechanism is gone.
What changed
spike-locks.ts→ticket-locks.ts. The claim is now onetickets/<STEM>.lock.mdper ticket holdingCLAIMED: <AGENT_ID>— the fileticketing_format.mddefines — instead ofPENDING:placeholders pre-filling.spike.md/.plan.md. The daemon still writes, commits, and pushes the locks before agents start (an agent only pushes at session end onto its own branch, so it can never place the lock in time; cloud runs can't push at all — #1320).The 6h staleness release is deleted (
releaseStaleSpikeLocks,SPIKE_LOCK_STALE_MS), per the issue: a coordinator can hold a ticket for days, and a timer releasing under a live agent re-opens the double-work window. Release is now explicit:sendReleaseTicketLock: delete, commit, best-effort push — a release only one machine sees would leave the ticket claimed where it matters).Readers switched over.
readTickets/readTicketmarklockedfrom the.lock.mdsibling's existence (pluslockedByfrom itsCLAIMED:line, shown as the badge/button tooltip); the lock file never renders as a ticket row; the daemon'sspikeCandidatesfilter is unchanged in shape but no longer runs a stale-lock sweep. Tickets wear a "claimed" badge in the list and on the detail page.Existence is meaning again: a
.plan.mdthat exists is a plan (the placeholder ambiguity is gone), which also un-breaks theplanned-quick-winsfail-closed path for tickets currently being planned.Not in this PR (flagged for follow-up)
planned-quick-wins.tsstill parses the pre-Improve lock mechanism #1420Effort: quick-win/Consensus:keys, so new-format plans never auto-queue — next slice..lock.md; unifying those into the whole-life lock is the issue's larger vision.Tests
🤖 Generated with Claude Code