ParentIDFilterFix - #39
Merged
Merged
Conversation
3 tasks
There was a problem hiding this comment.
Pull request overview
Fixes a bug in ReadOnlyModelController where the parentID filter was not actually being applied because Enumerable.Append(...) returns a new sequence and does not mutate the existing filter collection.
Changes:
- Assigns the result of
filters.Append(...)back tofiltersso the parent filter is included. - Materializes the appended filter sequence via
ToArray()to preserve the expectedRecordFilter<T>[]type passed into query/count operations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elwills
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue with parentID filters not being appended