Skip to content

Add new supported Chainflip assets#1003

Merged
0xh3rman merged 5 commits intomainfrom
chainflip-assets
Mar 12, 2026
Merged

Add new supported Chainflip assets#1003
0xh3rman merged 5 commits intomainfrom
chainflip-assets

Conversation

@0xh3rman
Copy link
Collaborator

Import ARBITRUM_USDT, ETHEREUM_WBTC, and SOLANA_USDT and update supported_assets to advertise these tokens. Ethereum now includes ETHEREUM_WBTC; Solana includes SOLANA_USDT; Arbitrum includes ARBITRUM_USDT. This enables support for the additional USDT/WBTC assets in the Chainflip provider.

Import ARBITRUM_USDT, ETHEREUM_WBTC, and SOLANA_USDT and update supported_assets to advertise these tokens. Ethereum now includes ETHEREUM_WBTC; Solana includes SOLANA_USDT; Arbitrum includes ARBITRUM_USDT. This enables support for the additional USDT/WBTC assets in the Chainflip provider.
@semanticdiff-com
Copy link

semanticdiff-com bot commented Mar 12, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  crates/swapper/src/chainflip/client/model.rs  7% smaller
  crates/swapper/src/chainflip/provider.rs  1% smaller
  crates/gem_evm/src/siwe.rs  0% smaller

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the capabilities of the Chainflip provider by integrating new stablecoin and wrapped Bitcoin assets across multiple blockchain networks. The changes enable the system to recognize and process ARBITRUM_USDT, ETHEREUM_WBTC, and SOLANA_USDT, thereby increasing the range of tokens available for swaps and enhancing the overall utility of the Chainflip service.

Highlights

  • New Asset Imports: Imported ARBITRUM_USDT, ETHEREUM_WBTC, and SOLANA_USDT asset constants into the Chainflip provider.
  • Expanded Supported Assets: Updated the supported_assets function to include ETHEREUM_WBTC for Ethereum, SOLANA_USDT for Solana, and ARBITRUM_USDT for Arbitrum, enabling their use within the Chainflip provider.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • crates/swapper/src/chainflip/provider.rs
    • Imported new asset constants for ARBITRUM_USDT, ETHEREUM_WBTC, and SOLANA_USDT.
    • Updated the supported_assets method to include the newly imported assets for Ethereum, Solana, and Arbitrum chains.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request extends the ChainflipProvider to support additional assets, specifically WBTC on Ethereum, USDT on Solana, and USDT on Arbitrum, by updating the supported_assets list. A critical issue was identified where the corresponding asset mappings in chainflip_asset_to_asset_id are missing, which could lead to incorrect swap result parsing for these new assets. Additionally, a suggestion was made to sort the asset lists alphabetically for improved readability.

@0xh3rman 0xh3rman merged commit 2ce9157 into main Mar 12, 2026
5 of 7 checks passed
@0xh3rman 0xh3rman deleted the chainflip-assets branch March 12, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants