Add metadata to PerpetualConfirmData

[DRadmir]

Added PerpetualConfirmMetadata for confirm scene details

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/primitives/src/lib.rs	100% smaller
crates/primitives/src/perpetual.rs	0% smaller
gemstone/src/models/transaction.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the data model for perpetual trade confirmations by introducing a dedicated PerpetualConfirmMetadata struct. This new structure encapsulates critical details like slippage, leverage, and profit/loss, which are then integrated into the existing PerpetualConfirmData. The primary goal is to provide a more comprehensive set of information for display in a confirmation scene, ensuring all necessary trade parameters are readily available and properly structured across the system, including for foreign function interface consumption.

Highlights

• New Data Structure: Introduced a new PerpetualConfirmMetadata struct to hold detailed information such as slippage, leverage, PnL, entry price, market price, and margin amount relevant for perpetual trade confirmation.
• Data Enrichment: The PerpetualConfirmData struct has been updated to include an instance of the new PerpetualConfirmMetadata, thereby enriching the data available for confirming perpetual transactions.
• FFI Compatibility: The new PerpetualConfirmMetadata struct and the updated PerpetualConfirmData have been made compatible with UFFI (Universal Foreign Function Interface) in the gemstone crate, allowing them to be exposed to other languages.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces PerpetualConfirmMetadata to hold details for the perpetual confirmation scene, adding it to PerpetualConfirmData. The changes in the primitives crate are well-implemented. However, in the gemstone crate, which handles the FFI layer with UniFFI, there are significant inconsistencies and a potential bug regarding type compatibility. I've provided a detailed comment on how to refactor this to ensure correctness and maintainability, bringing it in line with established patterns in the codebase.