-
Notifications
You must be signed in to change notification settings - Fork 41
Update for sui-transaction-builder 0.2.0 API changes #872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Refactor codebase to use sui-transaction-builder 0.2.0, replacing unresolved::Input with ObjectInput and updating transaction builder method calls (e.g., input -> object/pure, finish -> try_build). Adjust function signatures and usages throughout gem_sui and swapper crates to match the new API, and update dependencies in Cargo.toml accordingly.
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant refactoring effort to upgrade the project's transaction building logic to the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the codebase to use the sui-transaction-builder version 0.2.0 API. The changes, such as replacing unresolved::Input with ObjectInput and updating method calls like input to object/pure and finish to try_build, are applied consistently across the affected crates.
However, I've identified a performance regression in crates/swapper/src/cetus/provider.rs where TransactionBuilder::build_swap_transaction is called multiple times unnecessarily. I've left specific comments with suggestions on how to resolve this to avoid the redundant computation. Other than that, the migration to the new API looks good.
Eliminates sui-types and sui-transaction-builder from the swapper crate dependencies and code, including the removal of the AddressParseError conversion. Updates gem_sui to specify the correct version for sui-transaction-builder. This cleanup reduces unnecessary dependencies and streamlines error handling.
Created an issue MystenLabs/sui-rust-sdk#187, we need to update unit tests once it's deterministic