Skip to content

Conversation

@0xh3rman
Copy link
Collaborator

@0xh3rman 0xh3rman commented Jan 7, 2026

  • Refactor codebase to use sui-transaction-builder 0.2.0, replacing unresolved::Input with ObjectInput and updating transaction builder method calls (e.g., input -> object/pure, finish -> try_build).
  • Adjust function signatures and usages throughout gem_sui and swapper crates to match the new API, and update dependencies in Cargo.toml accordingly.

Created an issue MystenLabs/sui-rust-sdk#187, we need to update unit tests once it's deterministic

Refactor codebase to use sui-transaction-builder 0.2.0, replacing unresolved::Input with ObjectInput and updating transaction builder method calls (e.g., input -> object/pure, finish -> try_build). Adjust function signatures and usages throughout gem_sui and swapper crates to match the new API, and update dependencies in Cargo.toml accordingly.
@semanticdiff-com
Copy link

semanticdiff-com bot commented Jan 7, 2026

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant refactoring effort to upgrade the project's transaction building logic to the sui-transaction-builder 0.2.0 API. This ensures compatibility with the latest Sui development standards and leverages new functionalities, primarily by adjusting how transaction inputs are defined and how programmable transactions are constructed and finalized.

Highlights

  • API Migration: The codebase has been updated to align with the sui-transaction-builder 0.2.0 API, incorporating its latest changes and features.
  • Input Type Refactor: The unresolved::Input type has been replaced with the new ObjectInput type across the gem_sui and swapper crates, standardizing object input handling.
  • Transaction Builder Method Updates: Key transaction builder method calls have been modified, such as input being replaced by object or pure for different input types, and finish updated to try_build for transaction finalization.
  • Dependency Updates: The Cargo.toml and Cargo.lock files have been updated to reflect the new versions of sui-sdk-types and sui-transaction-builder (both to 0.2.0), along with several new and updated transitive dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly updates the codebase to use the sui-transaction-builder version 0.2.0 API. The changes, such as replacing unresolved::Input with ObjectInput and updating method calls like input to object/pure and finish to try_build, are applied consistently across the affected crates.

However, I've identified a performance regression in crates/swapper/src/cetus/provider.rs where TransactionBuilder::build_swap_transaction is called multiple times unnecessarily. I've left specific comments with suggestions on how to resolve this to avoid the redundant computation. Other than that, the migration to the new API looks good.

Eliminates sui-types and sui-transaction-builder from the swapper crate dependencies and code, including the removal of the AddressParseError conversion. Updates gem_sui to specify the correct version for sui-transaction-builder. This cleanup reduces unnecessary dependencies and streamlines error handling.
@0xh3rman 0xh3rman marked this pull request as ready for review January 8, 2026 05:05
@0xh3rman 0xh3rman merged commit d0ae997 into main Jan 8, 2026
4 checks passed
@0xh3rman 0xh3rman deleted the sui-tx-builder-0.2 branch January 8, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants