Add support for int<N> types in EIP712 value parsing

[DRadmir]

Extended the parse_value function to handle int types similarly to uint, allowing both numbers and strings as input. This improves compatibility with EIP712 typed data containing signed integer fields.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/gem_evm/src/eip712.rs	5% smaller
gemstone/src/message/eip712.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the EIP712 value parsing mechanism to properly interpret signed integer types (int<N>). By allowing both numeric and string inputs for these types, it ensures that the system can more robustly process and validate EIP712 structured data, particularly those involving signed integer fields, thereby improving overall compatibility.

Highlights

• EIP712 int<N> Type Support: The parse_value function now correctly handles int<N> types within EIP712 structured data.
• Flexible Input Parsing: For int<N> types, the function accepts both numerical and string representations, mirroring the existing behavior for uint<N> types.
• Improved Compatibility: This change enhances the system's compatibility with EIP712 typed data that includes signed integer fields.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for parsing int<N> types in EIP-712 messages, which is a valuable extension. However, the current implementation contains a critical issue by incorrectly mapping signed integers to an unsigned integer type (Uint256), which will fail for negative values. Additionally, there is some code duplication that could be refactored for better maintainability. My review provides detailed feedback on these points.