fix: SuiCoin model + serde_serializers updates

[0xh3rman]

Summary

• move SuiCoin into gem_sui models and update Sui RPC/preload usage
• backport serde_serializers improvements (visitors, safer number parsing, BigUint hex parsing)
• remove unused SuiCoin and serde deps from primitives

Testing

• cargo test -p serde_serializers
• cargo test -p gem_sui --features rpc
• cargo clippy -p serde_serializers -- -D warnings
• cargo clippy -p gem_sui --features rpc -- -D warnings

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
apps/daemon/src/consumers/mod.rs	100% smaller
apps/daemon/src/consumers/notifications/in_app_notifications_consumer.rs	100% smaller
crates/streamer/src/payload.rs	100% smaller
crates/streamer/src/steam_producer_queue.rs	100% smaller
crates/gem_sui/src/provider/preload_mapper.rs	48% smaller
crates/serde_serializers/src/bigint.rs	23% smaller
crates/serde_serializers/src/biguint.rs	11% smaller
crates/serde_serializers/src/u64.rs	3% smaller
Cargo.lock	Unsupported file format
crates/gem_sui/src/models/coin.rs	0% smaller
crates/gem_sui/src/provider/preload.rs	0% smaller
crates/gem_sui/src/rpc/client.rs	0% smaller
crates/primitives/Cargo.toml	Unsupported file format
crates/primitives/src/transaction_load_metadata.rs	0% smaller
crates/serde_serializers/Cargo.toml	Unsupported file format
crates/serde_serializers/src/lib.rs	0% smaller
crates/serde_serializers/src/string.rs	0% smaller
crates/serde_serializers/src/u32.rs	0% smaller
crates/serde_serializers/src/visitors/mod.rs	0% smaller
crates/serde_serializers/src/visitors/number_value.rs	0% smaller
crates/serde_serializers/src/visitors/string_or_number.rs	0% smaller
crates/serde_serializers/src/visitors/string_value.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the SuiCoin data model by relocating it to a more appropriate crate, gem_sui, to improve modularity and organization. Concurrently, it introduces several robust deserialization utilities within serde_serializers to handle various data types more safely and flexibly, particularly for numbers and hex-encoded values. These changes aim to enhance code structure, improve data parsing reliability, and optimize crate dependencies.

Highlights

• SuiCoin Model Relocation: The SuiCoin model has been moved from primitives to gem_sui models, centralizing Sui-specific data structures within the gem_sui crate. This change also updates its usage across Sui RPC and preload functionalities.
• Serde Serializers Enhancements: Significant improvements have been backported to the serde_serializers crate, including the introduction of custom visitors for more flexible deserialization, safer number parsing for u32 and u64, and enhanced BigUint hex parsing that now strictly requires a '0x' prefix for hex strings.
• Dependency Cleanup: Unused SuiCoin and serde_serializers dependencies have been removed from the primitives crate, streamlining its dependency tree and reducing potential bloat.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively refactors the SuiCoin model by moving it to the gem_sui crate and cleaning up its usage, which improves modularity. The backported improvements to serde_serializers are a significant enhancement, introducing the visitor pattern for safer and more efficient deserialization, especially for numeric types and hex strings. The changes are well-structured and include relevant tests. I have a couple of minor suggestions to further improve error messaging and code maintainability.