Add PerpetualPortfolioChartType enum

[gemdev111]

Introduces the PerpetualPortfolioChartType enum to represent chart types for perpetual portfolios. Updates the lib.rs export to include this new type.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/primitives/src/lib.rs	4% smaller
crates/primitives/src/portfolio.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @gemdev111, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new foundational data type, "PerpetualPortfolioChartType", within the primitives crate. Its purpose is to clearly delineate and categorize the various chart representations available for perpetual portfolios, such as displaying overall value versus profit and loss. This addition provides a structured way to handle different chart types, paving the way for more organized data visualization and logic in subsequent features.

Highlights

• New Enum Introduction: A new enum, "PerpetualPortfolioChartType", has been introduced to define different types of charts for perpetual portfolios.
• Chart Type Variants: This enum currently includes two variants: "Value" and "Pnl", likely representing portfolio value and profit/loss charts, respectively.
• Module Export: The new "PerpetualPortfolioChartType" enum is now exported from the "crates/primitives/src/lib.rs" module, making it accessible throughout the crate.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces the PerpetualPortfolioChartType enum. The implementation is straightforward, but I've found one potential issue. The enum is marked as Identifiable for Swift via typeshare, but it's missing the Eq and Hash traits in its derive macro. This is necessary for typeshare to correctly generate the Identifiable conformance for a CaseIterable enum in Swift. I've added a suggestion to fix this.

[gemini-code-assist]

The typeshare attribute specifies that the generated Swift enum should conform to Identifiable. For a CaseIterable enum, typeshare's default implementation for Identifiable requires the enum to also be Hashable. To make the enum Hashable in Swift, it needs to derive Eq and Hash in Rust. Without these, the generated Swift code may fail to compile.

Suggested change

	#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq)]
	#[derive(Debug, Clone, Copy, Serialize, Deserialize, PartialEq, Eq, Hash)]