Skip to content

Add 10% on top of smallest min amount#909

Merged
0xh3rman merged 2 commits intomainfrom
swap-min-amount
Jan 27, 2026
Merged

Add 10% on top of smallest min amount#909
0xh3rman merged 2 commits intomainfrom
swap-min-amount

Conversation

@0xh3rman
Copy link
Collaborator

No description provided.

@semanticdiff-com
Copy link

semanticdiff-com bot commented Jan 27, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  crates/swapper/src/swapper.rs  15% smaller

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modifies the GemSwapper's error handling for input amounts. Specifically, it adjusts the reported minimum amount in InputAmountError by adding a 10% buffer. This change aims to provide a more robust or user-friendly minimum threshold when an input amount is too low, ensuring that the suggested minimum is always slightly above the strict calculated minimum. The corresponding test case has been updated to validate this new calculation.

Highlights

  • Minimum Amount Adjustment: The logic for determining the minimum input amount in SwapperError::InputAmountError has been updated to add an additional 10% on top of the calculated smallest minimum amount. This ensures that the reported minimum amount is slightly higher than the absolute minimum.
  • Test Case Update: An existing test case in swapper.rs was updated to reflect the new 10% increase in the minimum amount, changing the expected value from 1264000 to 1390400.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a 10% buffer to the minimum amount in InputAmountError. While the intent is clear, the implementation introduces a risk of integer overflow, which could cause a panic in debug builds or produce incorrect results in release builds. I've provided a specific comment with a code suggestion to address this potential issue by using a safer calculation method.

@0xh3rman 0xh3rman marked this pull request as ready for review January 27, 2026 02:07
@0xh3rman 0xh3rman merged commit 17f3cfe into main Jan 27, 2026
5 checks passed
@0xh3rman 0xh3rman deleted the swap-min-amount branch January 27, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants