Fix min amount for thorchain(bnb decimal is 8 not 18)

[0xh3rman]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/swapper/src/thorchain/provider.rs	73% smaller
crates/swapper/src/thorchain/mod.rs	1% smaller
.claude/skills/review-changes/SKILL.md	Unsupported file format

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Thorchain swapper's error handling by introducing a mechanism to correctly interpret and display minimum input amounts in error messages. The primary impact is ensuring that users receive accurate feedback regarding required swap quantities, especially for assets with non-standard decimal representations like BNB, thereby improving the reliability and user experience of the swapping functionality.

Highlights

• Thorchain Minimum Amount Fix: Corrected the minimum amount calculation for Thorchain swaps, specifically addressing issues with BNB's decimal precision (8 instead of 18) to ensure accurate error messages.
• Error Mapping Function: Introduced a map_quote_error function to accurately adjust the min_amount in SwapperError::InputAmountError messages based on the asset's decimal count, converting the internal value to a user-friendly representation.
• Error Handling Integration: Integrated the new map_quote_error function into the get_quote call within the Thorchain provider to ensure correctly formatted minimum amount errors are returned to the user.
• New Code Review Guideline: Added a new guideline to the .claude/skills/review-changes/SKILL.md file, encouraging the use of one-liners for single-use variables to improve code conciseness.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue with Thorchain's minimum amount error reporting by correctly converting the amount based on the asset's decimals. A new map_quote_error function is introduced for this conversion, which is then used when fetching quotes. The implementation is sound and is accompanied by good unit tests. I have one suggestion to refactor the new function to be more idiomatic and efficient.