Use Simulator ID and set destination arch to arm64

[0xh3rman]

Try to fix iOS CI hang

[semanticdiff-com]

Review changes with  

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue causing iOS CI hangs by modifying the test-ios command within the justfile. The changes streamline the simulator targeting process by removing the dynamic detection of the iOS version and explicitly setting the destination architecture to arm64, aiming to improve the reliability and stability of iOS test runs in the CI environment.

Highlights

• iOS Test Command Refinement: Removed the dynamic detection of the iOS version for the simulator in the test-ios command, simplifying the simulator targeting process.
• Simulator Destination Update: Modified the xcodebuild command to explicitly set the destination architecture to arm64 and use only the simulator's ID, aiming to improve CI stability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• gemstone/justfile
  • Removed the IOS_VERSION variable extraction from the test-ios recipe.
  • Modified the xcodebuild command's -destination argument to use id=$DEVICE_ID,arch=arm64 instead of OS=$IOS_VERSION,id=$DEVICE_ID.
  • Updated the echo statement to reflect the removal of the iOS version from the output.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The pull request aims to fix an iOS CI hang by simplifying how the simulator is selected. The changes are a good step, but the script can be made more robust. I've identified that the script doesn't handle cases where no simulator is found, and it hardcodes the arm64 architecture, which could cause issues on Intel-based CI runners. My feedback includes a suggestion to address both of these points by adding an error check and dynamically setting the architecture based on the host system.