Add new chain assets and reserved fees for Near Intents#965
Conversation
Introduce asset constants and NEAR intent mappings for additional chains and tokens (Berachain, Gnosis, Stellar, XLayer, Monad, Plasma, Litecoin, BitcoinCash). Update imports to include new USDC/USDT asset IDs and add NEAR_INTENTS entries (native and token-specific) plus asset_key mappings. Also add reserved native fee amounts for Litecoin, BitcoinCash, Monad, XLayer and Plasma to ensure correct fee reservation for these chains.
Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the platform's support for various blockchain networks and their associated tokens. It integrates new asset identifiers and establishes the necessary NEAR intent mappings, enabling the system to recognize and interact with these additional chains and their specific assets. Furthermore, it sets up the required native fee reservations for these newly supported networks, ensuring smooth operation for transactions involving them. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces support for several new chains and tokens by adding their asset constants, NEAR intent mappings, and reserved fee amounts. The changes cover Berachain, Gnosis, Stellar, XLayer, Monad, Plasma, Litecoin, and BitcoinCash. The implementation is straightforward, adding new entries to existing data structures. I've pointed out a minor issue related to what appears to be incomplete support for Stellar USDC, where a constant is added but not used, and a related mapping is commented out. It would be cleaner to remove this code until the feature is fully ready.
Uh oh!
There was an error while loading. Please reload this page.