Remove gas_limit from Route struct

[0xh3rman]

The gas_limit field on Route was only used by Across (as intermediate storage between get_quote and get_quote_data) and set-but-never-read by Uniswap. Across now uses DEFAULT_DEPOSIT_GAS_LIMIT directly in get_quote_data. Also removes the unused gas_estimate from QuoteResult.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/swapper/src/across/provider.rs	0% smaller
crates/swapper/src/chainflip/provider.rs	0% smaller
crates/swapper/src/hyperliquid/provider/bridge.rs	0% smaller
crates/swapper/src/hyperliquid/provider/spot/provider.rs	0% smaller
crates/swapper/src/jupiter/provider.rs	0% smaller
crates/swapper/src/models.rs	0% smaller
crates/swapper/src/near_intents/provider.rs	0% smaller
crates/swapper/src/proxy/provider.rs	0% smaller
crates/swapper/src/relay/provider.rs	0% smaller
crates/swapper/src/thorchain/provider.rs	0% smaller
crates/swapper/src/uniswap/quote_result.rs	0% smaller
crates/swapper/src/uniswap/swap_route.rs	0% smaller
crates/swapper/src/uniswap/v3/provider.rs	0% smaller
crates/swapper/src/uniswap/v4/provider.rs	0% smaller
gemstone/src/gem_swapper/remote_types.rs	0% smaller
gemstone/tests/ios/GemTest/GemTest/Extension/Swapper+Ext.swift	0% smaller

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the data models within the swapper crate by eliminating redundant and unused fields. The gas_limit field in the Route struct and the gas_estimate field in the QuoteResult struct have been removed, as they were identified as either unnecessary intermediate storage or fields that were set but never read. This change streamlines the core data structures, reduces memory footprint, and simplifies the code across various swapper implementations by removing logic related to these fields.

Highlights

• Data Model Simplification: The gas_limit field has been removed from the Route struct, as it was either unused or its value was consistently derived from a constant.
• Unused Field Removal: The gas_estimate field has been removed from the QuoteResult struct, as it was being set but never utilized.
• Across Provider Optimization: The Across swapper now directly uses DEFAULT_DEPOSIT_GAS_LIMIT in get_quote_data, eliminating the need to store it in the Route struct.
• Code Cleanup: Various swapper providers (Chainflip, Hyperliquid, Jupiter, Near Intents, Proxy, Relay, Thorchain, Uniswap) have been updated to reflect the removal of the gas_limit field, simplifying their Route creation logic.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• crates/swapper/src/across/provider.rs
  • Removed gas_limit assignment during Route creation.
  • Updated gas_limit calculation to directly use DEFAULT_DEPOSIT_GAS_LIMIT.
• crates/swapper/src/chainflip/provider.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/hyperliquid/provider/bridge.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/hyperliquid/provider/spot/provider.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/jupiter/provider.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/models.rs
  • Removed the gas_limit field from the Route struct definition.
• crates/swapper/src/near_intents/provider.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/proxy/provider.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/relay/provider.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/thorchain/provider.rs
  • Removed gas_limit: None from Route initialization.
• crates/swapper/src/uniswap/quote_result.rs
  • Removed the gas_estimate field from the QuoteResult struct.
  • Removed gas_estimate assignment during QuoteResult creation.
• crates/swapper/src/uniswap/swap_route.rs
  • Removed gas_estimate parameter from build_swap_route function signature.
  • Removed gas_limit assignments within the build_swap_route function.
• crates/swapper/src/uniswap/v3/provider.rs
  • Removed gas_estimate variable declaration.
  • Updated build_swap_route function call to no longer pass gas_estimate.
• crates/swapper/src/uniswap/v4/provider.rs
  • Removed gas_estimate variable declaration.
  • Updated build_swap_route function call to no longer pass gas_estimate.
• gemstone/src/gem_swapper/remote_types.rs
  • Removed the gas_limit field from the SwapperRoute struct definition.

Activity

• No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the gas_limit field from the Route struct and the gas_estimate field from QuoteResult. The Across provider is refactored to use the DEFAULT_DEPOSIT_GAS_LIMIT constant directly, instead of relying on the gas_limit field passed via the Route struct. The gas_estimate field, which was unused in Uniswap providers, has also been removed. These changes have been applied consistently across the codebase, simplifying data structures by removing unused fields.