Replace custom URL parsing with Gemstone primitives - #357
Merged
Conversation
Solana NFT support added an `nft` parameter to the TransactionLoadMetadata.solana case, but the SolanaSignerTests call sites were not updated, breaking the SignerTests build. Pass `nft: nil` for the three existing non-NFT transfer cases; the signed transaction output is unchanged.
Replace in-app URL/deeplink and WalletConnect parsing with the shared GemstonePrimitives/uniffi helpers and update related code and tests. Changes include: - Android: remove custom URI decoding and WalletConnect parsing helpers; use walletConnectDecodeUrl and deeplinkDecodeUrl in PendingNavigationCoordinator and WebDeepLinks; adjust intent handling and tests to mock uniffi static functions. - iOS: add GemstonePrimitives package and bridging extensions (DeepLink <-> Gemstone, WalletConnect mapping), URLParser, and unit tests; update Features and ViewModels to use gemUrl/deeplink builders; update Navigation and RootScene handling to use deeplink-based URLAction. - Primitives: simplify DeepLink enum and add URLAction.deeplink case; update test utilities. - UI: Asset sharing now builds and shares a deeplink URL via Gemstone. - Remove legacy parsing files and Android/iOS parser tests that are replaced by the new GemstonePrimitives implementation. - Update core submodule pointer. These changes centralize deeplink and WalletConnect logic into the Gemstone primitives, reduce duplicated parsing code, and align tests to mock the new uniffi-based functions.
gemdev111
approved these changes
May 20, 2026
Remove legacy DeepLink cases (swap, buy, sell, setPriceAlert) and their handling across the codebase. Updates include pruning cases from the DeepLink enum, simplifying URLParser and Gemstone mapping, removing related navigation presentation flows in NavigationHandler, and cleaning up tests/mocks that referenced those deeplinks. Also includes a tiny whitespace fix in a generated file.
…share-asset-value # Conflicts: # core
DRadmir
force-pushed
the
348-wrong-share-asset-value
branch
from
May 21, 2026 07:56
6448c1e to
7d70ee2
Compare
…share-asset-value # Conflicts: # core
DRadmir
force-pushed
the
348-wrong-share-asset-value
branch
from
May 21, 2026 08:18
7d70ee2 to
99c8023
Compare
gemcoder21
reviewed
May 21, 2026
gemcoder21
reviewed
May 21, 2026
…share-asset-value # Conflicts: # core
Remove the gift redemption flow and consolidate URL/deeplink handling into a unified UrlAction path. Deleted gift-related UI, model fields and tests (gift codes, redemption option helpers) and removed getRedemptionOption from RewardsService and GemAPI. Refactored URL parsing and mapping: use Gemstone.urlAction/UrlAction across iOS and Android, added mapping extension (UrlAction -> Primitives) and updated Deeplink -> Nav route conversion. Android PendingNavigationCoordinator and Web deep link handling updated to consume UrlAction; tests adjusted accordingly. Note: this introduces breaking changes to DeepLink/Scenes shapes and API surface related to gift/redemption handling.
DRadmir
force-pushed
the
348-wrong-share-asset-value
branch
from
May 21, 2026 18:35
bdd5bba to
d5e1fcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move deeplink + WalletConnect URL parsing/building into the shared Rust core
(
gemstone), so iOS and Android use one implementationFix Wrong share asset value #348: Android asset share now shares a
gemwallet.comdeeplink instead ofthe raw wallet address
Delete duplicated per-platform parsers (iOS
URLParser/DeepLink, AndroidWebDeepLinks/WalletConnectLinks/UriComponentDecoding)Test
Closes #348