Show dash for empty memo on Android in Confrim - #787
Merged
Conversation
Match iOS: the confirm screen keeps the memo row for memo-supported transfers and renders "-" when no memo is set, instead of hiding the row.
gemcoder21
reviewed
Jul 27, 2026
gemcoder21
left a comment
gemcoder21
left a comment
Contributor
There was a problem hiding this comment.
can you add unit test? make sure we have same on iOS and android unit test
Move the empty-memo "-" fallback into ConfirmProperty.Memo so it is unit testable, and cover the empty-memo row in memoItemModel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #785
img:
