[codex] Add cached swap route preloading - #797
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Pool and route existence changes far less frequently than quote output. Repeating discovery calls on every quote adds avoidable node latency. Quote calls must remain live, but neither discovery nor quoting needs separate HTTP requests for each pair or route group.
Impact
Selecting a supported pair warms its route metadata before quote requests. Existing and missing fee tiers are reused to avoid quoting nonexistent pools. Quotes and liquidity-sensitive price calculations remain live.
For Smart Chain, Uniswap V3, PancakeSwap V3, and Uniswap V4 now each submit one discovery batch and one quote batch. The cold EVM path is reduced from 15 discovery requests plus 3 quote requests to 3 discovery requests plus 3 quote requests. A warm quote remains 3 live quote requests.
Validation
cargo test -p swapper— 265 passedcargo clippy -p swapper --lib -- -D warningsgit diff --checkcargo clippy -p swapper --all-targets -- -D warningsis currently blocked by two pre-existing boolean assertion warnings inthorchain/model.rsfrom the merged base branch.