Remove unused API endpoints and dead code - #939
Merged
Conversation
Delete client declarations that no caller reaches on either platform: the single transaction, rewards events and support action endpoints, the Android only redemption option endpoint, four Chain extensions, the duplicated QrScanField enum, and the EncodingType and PricesResponse models.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes client code that nothing calls.
Three device API endpoints were declared but never used: fetching a single transaction, fetching rewards events, and sending a support action. iOS and Android both had declarations for them, so both are removed together and the clients stay in sync. The backend still serves all three, so any of them can come back as a one line declaration when a feature needs it.
Also removes four unused Chain helpers, a duplicated QrScanField enum, and two unused models.
Nothing here was reachable, so behavior is unchanged.