Own the app update offer in one coordinator - #956
Merged
Conversation
The rule deciding whether an update is offered was evaluated in the app view model, in the update banner view model, and partly in the dialog, with the store mapping maintained twice in opposite directions. AppUpdateCoordinator now selects the release for the current store, persists it and exposes a single offer with an explicit delivery channel. Both view models became consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule that decides whether to offer an app update was written in three places at once, and the mapping between build flavor and store was kept twice in opposite directions. Changing anything about updates meant editing several unrelated files, and nothing warned you if you missed one.
Now a single component answers that question and says which way the update should be offered — a dialog for store builds, the in-app banner for the universal APK. Both screens just use its answer.
Behaviour is unchanged.