Keep stored delegations when the delegations request fails - #957
Merged
Conversation
The staking service turned any failure of the delegations request into an empty list, so the sync could not tell "the request failed" from "the user has no delegations" and deleted every stored delegation for the wallet. Return null on failure instead, matching PerpetualService.getPositions, and let the sync bail out before the delete diff. The runCatching guard in StakeRepository was dead code because the service never threw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android, a failed request for staking delegations was treated as "this wallet has no delegations", and the sync deleted every delegation it had stored.
A single network hiccup was enough to make a user's stake disappear from the app, most likely right after staking or unstaking, when the sync runs again immediately.
Now a failure is kept separate from an empty result, and nothing is deleted unless the request actually succeeded. iOS already behaved this way.