Remove EventPresenterService package - #973
Merged
Merged
Conversation
The package held a wrapper that only forwarded to ToastEventPresenter, a single-case event enum, and a factory that mapped that event to a ToastMessage. Move the presenter and the message mapping into PrimitivesComponents, next to the other ToastMessage builders, and drop the event indirection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the EventPresenterService package.
It contained a wrapper class that did nothing but forward to the toast presenter, an event enum with a single case, and a factory that turned that event into a toast message.
The presenter and the message mapping now live in PrimitivesComponents, next to the other toast message builders. Toasts look and behave exactly as before.