Own the NFT listing mode in one place - #974
Merged
Merged
Conversation
The NFT list screen served three routes plus the wallet-screen preview, and which listing it was got reassembled from two route arguments in the view model and three nullable callbacks in the composable. Derive an NftListMode once from the route arguments and pass it down, so the title, the receive action and the unverified row follow from it instead of from which callbacks a route left out. Drop the NFT error state and its UI: nothing ever wrote it, so the branch was unreachable and NftError had no remaining users.
DRadmir
marked this pull request as draft
August 26, 2026 03:30
Three switches over the mode in a row were a policy table in a function that otherwise only renders already-resolved state. Keep the exhaustive switch for the title, where a new mode has to choose a string, and read the mode directly where it decides the receive action and the unverified row. Drop the route argument test with it: it restated the mapping line by line without covering the metadata the routes actually set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NFT list screen is used for three things: all collections, one collection, and unverified collections. Which one it was had to be pieced together from route arguments in one place and from which callbacks the screen was given in another, so the two halves could disagree.
Now the screen figures out its mode once, and the title, the receive button and the unverified row follow from it.
Also removes the NFT error state and its "Try again" screen — nothing ever set it, so it could never appear.