Move recent activity recording into SelectAssetViewModel - #981
Merged
Conversation
Selecting an asset from the list recorded a recent activity entry from the navigation layer, which switched on an AssetSelectionType tag the view model produced only to carry that decision across the boundary. Fold the decision into SelectAssetFlow.selectionEffect, which already drives the same choice for select-style flows, and delete the enum.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking an asset from the select-asset list is what adds it to Recents, but that rule lived in the navigation layer instead of the screen's view model. The view model only passed a flag along so navigation could decide.
The rule now sits in the same flow table that already decides what a selection does, so it is visible in one place, and the flag type is gone. Behaviour is unchanged.