Retry the activities sync after a failed attempt - #982
Merged
Conversation
TransactionsViewModel marked a wallet as synced before the sync ran, and SyncTransactions swallowed every failure, so a sync that failed was never retried while the app stayed open. Report the sync outcome and release the marker when it did not succeed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Activity tab syncs once per wallet when you open it. If that sync failed — say the app started without a connection — it was marked as done anyway and never tried again, so the list stayed stale until you pulled to refresh.
Now a failed sync is not counted as done, and the next visit to the tab tries again.