Filter HuggingFace downloads by target model and adapter name (fixes #3) - #25
Merged
Conversation
NoaTal1996
requested review from
antonpibm,
freunda and
yairallouche
as code owners
May 13, 2026 08:08
antonpibm
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3. Adapter libraries used to be downloaded in full before any
filter was applied. This PR builds
allow_patternsfrom--base-model,--include-adapters, and--exclude-adaptersbefore callingsnapshot_download, so only the requested paths are fetched.Verification
Full compose produces a
BUILD.mdwith the same 12 adapters and paramcounts as the published
ibm-granite/granite-switch-4.1-3b-preview.Tests
Added
tests/composer/test_selective_download.py— 32 tests covering thehelpers, the
allow_patternsconstruction, a verbatim repro of issue #3,and real Hub metadata calls. Passes locally and on Vela1.