a couple of suggestions for the middleware PR - #170
Merged
Conversation
…el classes Move GenerateActionOptions and OutputConfig from inner classes of GenerateAction into standalone files. Update GenerateParams to hold GenerateActionOptions instead of ModelRequest, better reflecting the generation pipeline's data flow. Update middleware interfaces and tests accordingly.
…acking Add `messageIndex` field to `GenerateParams` to track the position in the conversation that the next model response will occupy. This mirrors the JS SDK's `messageIndex` and supports streaming chunk attribution and middleware that needs to track conversation position. - Add 3-arg constructor and `withMessageIndex()` to `GenerateParams` - Default `messageIndex` to message count when using 2-arg constructor - Update `withRequest()` to preserve `messageIndex` - Increment `messageIndex` during tool-loop iterations in `Genkit` - Add corresponding unit tests
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
xavidop
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.