Show appeal dates in steward submissions - #944
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughThe contribution model now stores when an appeal was submitted. Existing records are backfilled, backend serializers expose the timestamp, the appeal action persists it, and the steward submission card displays it. ChangesAppeal Timestamp
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Owner
participant SubmittedContributionViewSet
participant SubmittedContribution
participant SubmittedContributionSerializer
participant StewardSubmissionCard
Owner->>SubmittedContributionViewSet: Submit appeal
SubmittedContributionViewSet->>SubmittedContribution: Save appealed_at
SubmittedContributionViewSet->>SubmittedContributionSerializer: Serialize appeal response
SubmittedContributionSerializer-->>Owner: Return appealed_at
SubmittedContributionSerializer->>StewardSubmissionCard: Provide appeal fields
StewardSubmissionCard-->>Owner: Render appeal date and reason
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Persist the appeal timestamp and expose it through submission APIs. Backfill existing appeal dates from state transitions or internal appeal notes. Display the timestamp alongside the appeal reason in the steward review card.
Summary by CodeRabbit
New Features
Bug Fixes