Skip to content

Show appeal dates in steward submissions - #944

Merged
JoaquinBN merged 1 commit into
devfrom
JoaquinBN/add-appeal-date-reason
Jul 19, 2026
Merged

Show appeal dates in steward submissions#944
JoaquinBN merged 1 commit into
devfrom
JoaquinBN/add-appeal-date-reason

Conversation

@JoaquinBN

@JoaquinBN JoaquinBN commented Jul 19, 2026

Copy link
Copy Markdown
Collaborator

Persist the appeal timestamp and expose it through submission APIs. Backfill existing appeal dates from state transitions or internal appeal notes. Display the timestamp alongside the appeal reason in the steward review card.

Summary by CodeRabbit

  • New Features

    • Appeal records now include the date and time the appeal was submitted.
    • Steward submission details display the appeal date alongside the appeal reason.
    • Appeal timestamps are available in submission and steward views.
  • Bug Fixes

    • Existing appeal records are populated with their original appeal timestamps where available.

@coderabbitai

coderabbitai Bot commented Jul 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 81c3e0de-a520-4ea5-a43c-0c0feec4c753

📥 Commits

Reviewing files that changed from the base of the PR and between 398bb63 and b0bafef.

📒 Files selected for processing (8)
  • backend/contributions/migrations/0081_submittedcontribution_appealed_at.py
  • backend/contributions/models.py
  • backend/contributions/serializers.py
  • backend/contributions/tests/test_appeal.py
  • backend/contributions/tests/test_steward_permissions.py
  • backend/contributions/views.py
  • frontend/src/components/StewardSubmissionCard.svelte
  • frontend/src/tests/StewardSubmissionCard.test.js

📝 Walkthrough

Walkthrough

The contribution model now stores when an appeal was submitted. Existing records are backfilled, backend serializers expose the timestamp, the appeal action persists it, and the steward submission card displays it.

Changes

Appeal Timestamp

Layer / File(s) Summary
Timestamp field and historical backfill
backend/contributions/models.py, backend/contributions/migrations/0081_submittedcontribution_appealed_at.py
Adds nullable appealed_at storage and backfills existing appeals from state transitions or appeal notes.
Appeal persistence and API exposure
backend/contributions/views.py, backend/contributions/serializers.py, backend/contributions/tests/*
Stores the timestamp when an appeal is submitted, exposes appeal fields as read-only, and verifies API responses.
Steward appeal timestamp display
frontend/src/components/StewardSubmissionCard.svelte, frontend/src/tests/StewardSubmissionCard.test.js
Displays the formatted appeal timestamp alongside the appeal reason and tests the rendered output.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Owner
  participant SubmittedContributionViewSet
  participant SubmittedContribution
  participant SubmittedContributionSerializer
  participant StewardSubmissionCard
  Owner->>SubmittedContributionViewSet: Submit appeal
  SubmittedContributionViewSet->>SubmittedContribution: Save appealed_at
  SubmittedContributionViewSet->>SubmittedContributionSerializer: Serialize appeal response
  SubmittedContributionSerializer-->>Owner: Return appealed_at
  SubmittedContributionSerializer->>StewardSubmissionCard: Provide appeal fields
  StewardSubmissionCard-->>Owner: Render appeal date and reason
Loading

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main user-facing change: showing appeal dates in steward submissions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch JoaquinBN/add-appeal-date-reason

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@JoaquinBN
JoaquinBN merged commit 9e794a1 into dev Jul 19, 2026
3 checks passed
@JoaquinBN
JoaquinBN deleted the JoaquinBN/add-appeal-date-reason branch July 19, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant