Skip to content

fix: support proof-bearing validator joins - #206

Merged
MuncleUscles merged 2 commits into
v2-devfrom
fix/vesting-operator-proof
Aug 9, 2026
Merged

fix: support proof-bearing validator joins#206
MuncleUscles merged 2 commits into
v2-devfrom
fix/vesting-operator-proof

Conversation

@MuncleUscles

@MuncleUscles MuncleUscles commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • replace both retired validator-join ABI surfaces with proof-bearing calls:
    • validatorJoin(uint256[2],bytes)
    • vestingValidatorJoin(uint256[2],bytes,uint256)
  • export a private-key-local operator registration helper matching the consensus EIP-191 domain and Solidity ABI encoding
  • resolve the live chain ID and ValidatorWalletFactory registrar, bind each proof to the joining owner, and verify it before submission
  • accept only proof packages in the SDK actions; raw operator keys are never retained

Root cause

Consensus C4 requires a secp256k1 public key and a chain/registrar/owner-bound proof of possession whenever a validator wallet is created. The SDK still encoded the removed address-only and zero-argument join surfaces, which caused Explorer vesting joins to revert and left JS/CLI/Python tooling unable to join validators.

Validation

  • npm test -- --run — 122/122, no type errors
  • npm run build
  • targeted ESLint on the changed source/tests
  • git diff --check
  • deterministic proof vector matches the exact consensus helper; wrong-key/domain and invalid-registration coverage included

Companion consumers

Depends-On: https://github.com/genlayerlabs/genlayer-consensus/pull/1285

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 26229a0a-688b-473b-90bc-b2e27030d436

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MuncleUscles
MuncleUscles force-pushed the fix/vesting-operator-proof branch from cdcbdf7 to ca7a788 Compare August 9, 2026 09:20
@MuncleUscles MuncleUscles changed the title fix: support proof-bearing vesting validator joins fix: support proof-bearing validator joins Aug 9, 2026
@MuncleUscles
MuncleUscles marked this pull request as ready for review August 9, 2026 15:11
@MuncleUscles
MuncleUscles merged commit 6f12738 into v2-dev Aug 9, 2026
12 of 14 checks passed
MuncleUscles added a commit that referenced this pull request Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant