fix: support proof-bearing validator joins - #206
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MuncleUscles
force-pushed
the
fix/vesting-operator-proof
branch
from
August 9, 2026 09:20
cdcbdf7 to
ca7a788
Compare
MuncleUscles
marked this pull request as ready for review
August 9, 2026 15:11
MuncleUscles
added a commit
that referenced
this pull request
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validatorJoin(uint256[2],bytes)vestingValidatorJoin(uint256[2],bytes,uint256)ValidatorWalletFactoryregistrar, bind each proof to the joining owner, and verify it before submissionRoot cause
Consensus C4 requires a secp256k1 public key and a chain/registrar/owner-bound proof of possession whenever a validator wallet is created. The SDK still encoded the removed address-only and zero-argument join surfaces, which caused Explorer vesting joins to revert and left JS/CLI/Python tooling unable to join validators.
Validation
npm test -- --run— 122/122, no type errorsnpm run buildgit diff --checkCompanion consumers
Depends-On: https://github.com/genlayerlabs/genlayer-consensus/pull/1285