Added ebuilds for HPX, Likwid, and LibGeoDecomp#49
Conversation
There was a problem hiding this comment.
No real need to subshell here.
…X, also fixed shortcomings as requested by jlec in https://github.com/gentoo-science/sci/pull/49/files#r2931081
There was a problem hiding this comment.
Nitpicking, but this isn't a sentence, so you can drop the "." at the end.
There was a problem hiding this comment.
More elegant would me this:
src_install() {
DOCS=( README )
use doc && HTML_DOCS=( doc/html/* )
cmake-utils_src_install
}
There was a problem hiding this comment.
There is so much automagic built in into portage... Good stuff!
There was a problem hiding this comment.
Could you please move this up and follow following sorting:
EAPI
inherit
DESCRIPTION
HOMPAGE
SRC_URI
SLOT
LICENSE
KEYWORDS
IUSE
…alent function definitions, re-added test build functions as tests wouldn't otherwise be run
|
Hey Justin, could you give me another review? I've tried to honor all hints in all four added ebuilds. Thanks! |
There was a problem hiding this comment.
I think, here you need to run cmake-utils_src_compile, because you like the eclass function to be run and not the package managers default function.
There was a problem hiding this comment.
Alright, I'm reverting those.
|
Thanks for all your patience and your contribution. |
Added ebuilds for HPX, Likwid, and LibGeoDecomp
|
Thanks for the mentoring! |
2 participants
For the project homepages please see
http://www.libgeodecomp.org/
http://code.google.com/p/likwid/
http://stellar.cct.lsu.edu/tag/hpx/