-
Notifications
You must be signed in to change notification settings - Fork 2.2k
dev-ruby/whole_history_rating: new package #13032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request assignmentSubmitter: @Alessandro-Barbieri dev-ruby/whole_history_rating: @gentoo/proxy-maint (new package) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
|
|
||
| inherit ruby-fakegem | ||
|
|
||
| DESCRIPTION="A pure ruby implementation of Remi Coulom's Whole-History Rating algorithm." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since that's not a proper sentence, no dot at the end.
| LICENSE="MIT" | ||
| SLOT="0" | ||
| KEYWORDS="~amd64" | ||
| IUSE="test" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RESTRICT="!test? ( test )"
| EAPI=7 | ||
|
|
||
| USE_RUBY="ruby24 ruby25 ruby26" | ||
| RUBY_FAKEGEM_TASK_DOC="" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know this eclass. Is this empty assignment necessary/customary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that dozen of ebuilds set this empty and I can't find here if it's necessary or not
Package-Manager: Portage-2.3.77, Repoman-2.3.17 Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
49b3e12 to
0f20b78
Compare
Pull request CI reportReport generated at: 2019-10-25 10:20 UTC Issues already there before the PR (double-check them): |
Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Alessandro Barbieri lssndrbarbieri@gmail.com