Skip to content

Conversation

@Alessandro-Barbieri
Copy link
Contributor

Package-Manager: Portage-2.3.76, Repoman-2.3.17
Signed-off-by: Alessandro Barbieri lssndrbarbieri@gmail.com

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @Alessandro-Barbieri
Areas affected: ebuilds
Packages affected: dev-ruby/whole_history_rating

dev-ruby/whole_history_rating: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Sep 25, 2019

inherit ruby-fakegem

DESCRIPTION="A pure ruby implementation of Remi Coulom's Whole-History Rating algorithm."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since that's not a proper sentence, no dot at the end.

LICENSE="MIT"
SLOT="0"
KEYWORDS="~amd64"
IUSE="test"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RESTRICT="!test? ( test )"

EAPI=7

USE_RUBY="ruby24 ruby25 ruby26"
RUBY_FAKEGEM_TASK_DOC=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know this eclass. Is this empty assignment necessary/customary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that dozen of ebuilds set this empty and I can't find here if it's necessary or not

Package-Manager: Portage-2.3.77, Repoman-2.3.17
Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2019-10-25 10:20 UTC
Newest commit scanned: 0f20b78
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/5b71020/output.html#net-libs/nodejs
https://qa-reports.gentoo.org/output/gentoo-ci/5b71020/output.html#sci-mathematics/kodkod

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants