x11-misc/sddm-9999: PAM has been removed upstream include files manually#278
Closed
FireBurn wants to merge 1 commit intogentoo:masterfrom
Closed
x11-misc/sddm-9999: PAM has been removed upstream include files manually#278FireBurn wants to merge 1 commit intogentoo:masterfrom
FireBurn wants to merge 1 commit intogentoo:masterfrom
Conversation
sddm/sddm@ae072f9 PAM modules are distribution specific and are ultimately better fit in the distribution packaging. Having them in SDDM brings extra burden to the already stretched developers and maintainers. Plus a handful of distributions currently patch the (Arch) PAM modules, where having the full set in their own tree would make for cleaner solution. Signed-off-by: Mike Lothian <mike@fireburn.co.uk>
a17r
suggested changes
Mar 6, 2024
| "${FILESDIR}/${PN}-0.21.0-Xsession.patch" # bug 611210 | ||
| "${FILESDIR}/${PN}-0.20.0-sddm.pam-use-substack.patch" # bug 728550 | ||
| "${FILESDIR}/${PN}-0.21.0-disable-etc-debian-check.patch" | ||
| "${FILESDIR}/${PN}-0.21.0-no-default-pam_systemd-module.patch" # bug 669980 |
Member
There was a problem hiding this comment.
simply dropping this patch is re-introducing bug 669980.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sddm/sddm@ae072f9
PAM modules are distribution specific and are ultimately better fit in the distribution packaging.
Having them in SDDM brings extra burden to the already stretched developers and maintainers. Plus a handful of distributions currently patch the (Arch) PAM modules, where having the full set in their own tree would make for cleaner solution.
I've added the pam files that uses to be installed into the files directory and manually installed them, this keeps things working. Not sure if they should be versioned or not