Skip to content

sci-biology/open-ephys-gui: version bump#1111

Closed
malfatti wants to merge 3 commits intogentoo:masterfrom
malfatti:sci-biology/open-ephys-gui
Closed

sci-biology/open-ephys-gui: version bump#1111
malfatti wants to merge 3 commits intogentoo:masterfrom
malfatti:sci-biology/open-ephys-gui

Conversation

@malfatti
Copy link
Contributor

@malfatti malfatti commented Sep 5, 2021

This will bump sci-biology/open-ephys-gui to version 0.5.5. This allows for dropping the <gcc-9 dependency.

@Nowa-Ammerlaan Nowa-Ammerlaan self-assigned this Sep 5, 2021
@malfatti
Copy link
Contributor Author

malfatti commented Sep 5, 2021

Hey @AndrewAmmerlaan,

Thanks a lot for your reviews. As I commented above, I could not drop the build dir override nor bump the EAPI version. The software expect the build dir to be under Build/; and with EAPI=8 I cannot pass the configure phase (getting invalid build type error), even though the patch to fix this is applied correctly. CMake is somehow setting the build type to RelWithDebInfo instead of Gentoo. It's weird because RelWithDebInfo is actually a valid build type. I kept EAPI=7, since I could not solve this issue.

Those 2 issues aside, all other suggestions were applied.

EDIT: I just noticed I forgot to update the live versions! I'll update them as soon as they finish compiling.
EDIT2: I got a file collision with the udev rules, as soon as I fix it I'll update all ebuilds.

Cheers :)

@Nowa-Ammerlaan
Copy link
Member

Those 2 issues aside, all other suggestions were applied.

Thanks 👍

We should still also do udev_reload in the pkg_postrm phase, because after removing the package we should reload udev to account for the removed rules file. I'm not sure if udev misbehaves if we don't reload it after removing, but other ebuilds are doing this so it is probably the right thing to do.

EDIT2: I got a file collision with the udev rules, as soon as I fix it I'll update all ebuilds.

You can probably just rename the rules file with udev_newrules instead of udev_dorules

@malfatti
Copy link
Contributor Author

malfatti commented Sep 7, 2021

We should still also do udev_reload in the pkg_postrm phase, because after removing the package we should reload udev to account for the removed rules file. I'm not sure if udev misbehaves if we don't reload it after removing, but other ebuilds are doing this so it is probably the right thing to do.

Sorry I scrolled through this, now it is added.

You can probably just rename the rules file with udev_newrules instead of udev_dorules

Just did, now all versions are merging and the software works. Thanks a lot :)

@gentoo-bot gentoo-bot closed this in 62113d3 Sep 7, 2021
@Nowa-Ammerlaan
Copy link
Member

Perfect, Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments