Skip to content

sci-physics/spheno: init ebuild#1156

Closed
APN-Pucky wants to merge 4 commits intogentoo:masterfrom
APN-Pucky:master
Closed

sci-physics/spheno: init ebuild#1156
APN-Pucky wants to merge 4 commits intogentoo:masterfrom
APN-Pucky:master

Conversation

@APN-Pucky
Copy link
Member

My first attempt of contributing to the gentoo science project.
I intend to PR more ebuilds for high energy physics, mostly originating from https://hepforge.org/projects.
But for starters I decided to try a simple ebuild and maybe get some feedback.

Cheers APN

Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
@Nowa-Ammerlaan
Copy link
Member

Excellent 👍

After emerging this ebuild I'm getting a couple of QA notices:

* QA Notice: Files built without respecting CFLAGS have been detected
*  Please include the following list of files in your report:
* /usr/bin/SPheno


* QA Notice: Files built without respecting LDFLAGS have been detected
*  Please include the following list of files in your report:
* /usr/bin/SPheno

Would you like to fix these as well? For ::sci we are not very strict so I'm also okay with merging this as is.

You can enable these checks for yourself by emerging the ebuild in an environment with all *FLAGS defined (CFLAGS, CXXFLAGS, FFLAGS, FCFLAGS) and with LDFLAGS="-Wl,--defsym=__gentoo_check_ldflags__=0. This should be documented somewhere but I can't seem to find it at the moment.

Signed-off-by: Alexander Puck Neuwirth <alexander@neuwirth-informatik.de>
@APN-Pucky
Copy link
Member Author

APN-Pucky commented Jul 20, 2022

You can enable these checks for yourself by emerging the ebuild in an environment with all *FLAGS defined (CFLAGS, CXXFLAGS, FFLAGS, FCFLAGS) and with LDFLAGS="-Wl,--defsym=__gentoo_check_ldflags__=0. This should be documented somewhere but I can't seem to find it at the moment.

I found it here: https://wiki.gentoo.org/wiki/Package_testing
And fixed it by adding the {C,F,FC,LD}FLAGS to the patch.

@Nowa-Ammerlaan
Copy link
Member

You can enable these checks for yourself by emerging the ebuild in an environment with all *FLAGS defined (CFLAGS, CXXFLAGS, FFLAGS, FCFLAGS) and with LDFLAGS="-Wl,--defsym=__gentoo_check_ldflags__=0. This should be documented somewhere but I can't seem to find it at the moment.

I found it here: https://wiki.gentoo.org/wiki/Package_testing And fixed it by adding the {C,F,FC,LD}FLAGS to the patch.

Excellent 👍 Thanks, Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments