Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
======================================
Coverage 0% 0%
======================================
Files 14 16 +2
Lines 782 957 +175
======================================
- Misses 782 957 +175
Continue to review full report at Codecov.
|
AkihiroSuda
approved these changes
May 6, 2019
Collaborator
AkihiroSuda
left a comment
There was a problem hiding this comment.
LGTM
@jessfraz PTAL
Collaborator
|
waaah so sorry for the delay seems like it needs a rebase, @AkihiroSuda i think you have merge rights please feel free to merge in the future I feel badly being the hold up :) |
The file is not available at the old location, so just build it.
… command for improved visibility into which runc is being used. Also improved error messaging when runc isn't found. Don't store runc in a tmp directory, but store in the state directory.
46f1db9 to
52e6930
Compare
Contributor
Author
|
@jessfraz no worries, we are all busy 😄 @AkihiroSuda @jessfraz I have rebased. Reminder, this PR is on top of #230 . |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #231 . Depends on #230 being merged.
There was some flakiness with the embedded runc. A system installed runc would previously be used inadvertently. This is an attempt to fix bugs, but also harden some of the logic and error handling around embedding to make sure we are using the runc that the user expected.
What I did
.local/share/img/bin)img versionImprovements