Skip to content

Comments

Add static IP command line switch#12

Merged
jessfraz merged 2 commits intogenuinetools:masterfrom
SotolitoLabs:add-ip-static-addr
Jan 2, 2019
Merged

Add static IP command line switch#12
jessfraz merged 2 commits intogenuinetools:masterfrom
SotolitoLabs:add-ip-static-addr

Conversation

@imcsk8
Copy link
Contributor

@imcsk8 imcsk8 commented Dec 5, 2018

There are use cases in which a container needs a persistent static IP.
This patch adds a switch to set a static IP for a container.

Eg.

"hooks": {
"prestart": [
{
"path": "/home/example/go/src/github.com/genuinetools/netns/netns",
"args": ["netns", "--static-ip", "172.19.0.2"]
}
]
}

closes #11

There are use cases in which a container needs a persistent static IP.
This patch adds a switch to set a static IP for a container.

Eg.

"hooks": {
                "prestart": [
                	{
                        	"path": "/home/example/go/src/github.com/genuinetools/netns/netns",
                        	"args": ["netns", "--static-ip", "172.19.0.2"]
                	}
                ]
        }
@imcsk8 imcsk8 mentioned this pull request Dec 5, 2018
@imcsk8
Copy link
Contributor Author

imcsk8 commented Dec 5, 2018

PTAL @jessfraz

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #12 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #12      +/-   ##
=========================================
- Coverage   10.66%   10.5%   -0.16%     
=========================================
  Files           5       5              
  Lines         272     276       +4     
=========================================
  Hits           29      29              
- Misses        241     245       +4     
  Partials        2       2
Impacted Files Coverage Δ
network/create.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de81619...715cf14. Read the comment docs.

@jessfraz
Copy link
Collaborator

jessfraz commented Jan 2, 2019

thanks!

@jessfraz jessfraz merged commit 71ab69a into genuinetools:master Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Static IP

2 participants