Throw InvalidCredentialsException with GoogleMBP #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When an invalid clientID / privateKey combination is used with the GoogleMapsBusinessProvider, throw an InvalidCredentialsException instead of a NoResultException. * Test that the exception is thrown with the testGetGeocodedDataWithInvalidClientIdAndKey(), and testGetGeocodedDataWithINvalidClientIdAndKeyNoSsl() methods. * Add two tests for the GoogleMapsProvider to test that expected results are returned when using a valid API Key (commented example added to phpunit.xml.dist and README.md) and that an InvalidCredentialsException is thrown when an incorrect API Key is used.
Member
|
looks good to me |
Member
|
👍 |
willdurand
added a commit
that referenced
this pull request
May 21, 2014
…eption_with_bad_google_maps_key Throw InvalidCredentialsException with GoogleMBP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combination is used with the
GoogleMapsBusinessProvider, throw an
InvalidCredentialsException instead of a
NoResultException.
testGetGeocodedDataWithInvalidClientIdAndKey(),
and
testGetGeocodedDataWithINvalidClientIdAndKeyNoSsl()
methods.
test that expected results are returned when using
a valid API Key (commented example added to
phpunit.xml.dist and README.md) and that an
InvalidCredentialsException is thrown when an
incorrect API Key is used.