Fix OpenStreetMap provider creation issues#8
Merged
fillerwriter merged 1 commit intogeocoder-php:masterfrom Jul 25, 2014
Merged
Fix OpenStreetMap provider creation issues#8fillerwriter merged 1 commit intogeocoder-php:masterfrom
fillerwriter merged 1 commit intogeocoder-php:masterfrom
Conversation
The OpenStreetMap provider only works properly on the first instance. I don't fully understand why but it seems this becuase the constructor was overwritten during creation. I've fixed this to match the way this is done in other providers which seems to work.
fillerwriter
pushed a commit
that referenced
this pull request
Jul 25, 2014
Fix OpenStreetMap provider creation issues
Member
|
Thanks for the PR, RJ! |
alanpoulain
added a commit
to alanpoulain/universal-geocoder
that referenced
this pull request
Sep 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OpenStreetMap provider only works properly on the first instance.
I don't fully understand why but it seems this becuase the constructor
was overwritten during creation. I've fixed this to match the way
this is done in other providers which seems to work.