feat: add SSRF protection for mod downloads#82
Merged
Conversation
- Denies any local IP addresses - Validates resolved IP and pins actual DNS query to it - Run validation on every redirect (max 10 redirects) - add tests for good measure
Fleeym
marked this pull request as draft
July 20, 2026 20:00
Member
Author
|
Draft for now, still need to test a little more. |
Member
Author
|
Tested, seems good enough |
Fleeym
marked this pull request as ready for review
July 21, 2026 20:48
- renamed mod_download_http_client to pin_dns_http_client - added docs for the client and pin_dns::PINNED_ADDR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mod download requests were allowed to basically do anything, very bad for security since local addresses could be accessed.
Hole wasn't really that big since it was only doing a GET request, and no data was returned to the caller, but still, better to plug the hole than to keep it.
Changelog: