Upload mod logos to S3 - #90
Merged
Merged
Conversation
Fleeym
reviewed
Aug 8, 2026
Fleeym
reviewed
Aug 8, 2026
Member
|
Thrown my 2 cents here, they are mostly nitpicks for performance. |
dankmeme01
added a commit
that referenced
this pull request
Aug 11, 2026
* implement logo uploads to s3 * update query cache * address review comments * update sqlx queries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mod logos are stored as
mods/mod.id/logo.png, same bucket as mod files themselvesUpdated asynchronously every time a mod is approved, as well as retroactively during program launch for all mods who have a logo in the database.