Remove GeoExt.tree.Panel and ensure drag & drop functionality by enhancing LayersTree-store#96
Merged
marcjansen merged 3 commits intogeoext:masterfrom Oct 21, 2015
Merged
Conversation
6d2aa84 to
818448b
Compare
83fe3bd to
f033492
Compare
Contributor
There was a problem hiding this comment.
I would prefer "onLayerCollectionAdd" and ...
f033492 to
a35546a
Compare
Member
Author
|
@KaiVolland as you suggested, methods are now renamed as you suggested |
|
It fixes the issue. I also checked with the "length" of the layers. How many can you have. I earlier described it would overwrite and not show all layers after a give numbers of layers in the legend. |
Member
Author
|
@AndersVittrup, cool thanks for the feedback |
a35546a to
bc8254c
Compare
Contributor
|
All seems fine to me. Please merge. 👯 |
Member
Author
|
Thanks for the reviews and tests @KaiVolland & @AndersVittrup! Again a hat-tip to the input of @weskamm |
marcjansen
added a commit
that referenced
this pull request
Oct 21, 2015
Remove GeoExt.tree.Panel and ensure drag & drop functionality by enhancing LayersTree-store
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR suggests a larger refactoring of the tree classes. In particular the following is suggested:
GeoExt.tree.Paneland instead enhance theGeoExt.data.store.LayersTreeto handle any possible drag/drop eventsGeoExt.tree.Panelto a dedicated utility classshowLayerGroupNodeconfig fromGeoExt.data.store.LayersTreeAdditionally a bug is fixed: (we could not actually handle the store remove event before 36b8a81)
If you have been using the
GeoExt.tree.panelpreviously, you now need to refactor your code fromto
Fixes #91
Please review. /cc @KaiVolland, @chrismayer & @AndersVittrup
The work in this PR has been done by @weskamm and me.