Skip to content

updated vector data and visualisation notebook#78

Merged
tomkralidis merged 2 commits intomasterfrom
updates_by_krishna
Aug 12, 2022
Merged

updated vector data and visualisation notebook#78
tomkralidis merged 2 commits intomasterfrom
updates_by_krishna

Conversation

@krishnaglodha
Copy link
Copy Markdown
Member

I have enhanced the current notebook by adding vector data code from my notebooks.

For visualisation, I have added abilities to show popup

@justb4 justb4 added the enhancement New feature or request label Jun 13, 2022
@justb4 justb4 added this to the FOSS4G 2022 milestone Jun 13, 2022
@justb4 justb4 self-requested a review June 24, 2022 09:31
Copy link
Copy Markdown
Member

@justb4 justb4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution! So overall this PR adds (nothing is deleted):

  • GeoPandas sections to chapter 4 "Vector Data" [4]
  • ipyleaflet popups to Chapter 7 "Visualization" [7]

Both additions are valuable, no comments on [7]. Any issues with execution (did not have time) can be fixed on the fly.
Some comments on [4]:

  • GeoPandas should definitely be in. There is quite some text/cells now. Suggestion: split into a "Quickstart" and optional "More GeoPandas". Mainly for time (4h workshop) reasons.
  • add some text on comparing OGR, Fiona and GP.
  • knowledge of Pandas is assumed (is just like a pandas DataFrame), introduce Pandas.
  • Postgis example: does the Notebook assume running Postgres/PostGIS locally?
  • aren't extra dependencies, like GeoPandas, needed in the Dockerfile ?

Maybe @tomkralidis @francbartoli @pvgenuchten @kalxas @ et al can take a look at this PR as well? After some of the above comments fixed, I think we can merge, run, review and fix from there. It is hard to review notebooks from within GitHub.

@tomkralidis
Copy link
Copy Markdown
Member

  • GeoPandas is already a requirement
  • turn PostgreSQL/PostGIS executable cells into text with suggestion text if folks have PostgreSQL/PostGIS and load data, to run sample Python code

@tomkralidis tomkralidis merged commit 64b8567 into master Aug 12, 2022
@tomkralidis tomkralidis deleted the updates_by_krishna branch August 12, 2022 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants