updated vector data and visualisation notebook#78
Merged
tomkralidis merged 2 commits intomasterfrom Aug 12, 2022
Merged
Conversation
justb4
requested changes
Jun 24, 2022
Member
justb4
left a comment
There was a problem hiding this comment.
Thanks for this contribution! So overall this PR adds (nothing is deleted):
- GeoPandas sections to chapter 4 "Vector Data" [4]
- ipyleaflet popups to Chapter 7 "Visualization" [7]
Both additions are valuable, no comments on [7]. Any issues with execution (did not have time) can be fixed on the fly.
Some comments on [4]:
- GeoPandas should definitely be in. There is quite some text/cells now. Suggestion: split into a "Quickstart" and optional "More GeoPandas". Mainly for time (4h workshop) reasons.
- add some text on comparing OGR, Fiona and GP.
- knowledge of Pandas is assumed (is just like a pandas DataFrame), introduce Pandas.
- Postgis example: does the Notebook assume running Postgres/PostGIS locally?
- aren't extra dependencies, like GeoPandas, needed in the Dockerfile ?
Maybe @tomkralidis @francbartoli @pvgenuchten @kalxas @ et al can take a look at this PR as well? After some of the above comments fixed, I think we can merge, run, review and fix from there. It is hard to review notebooks from within GitHub.
Member
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have enhanced the current notebook by adding vector data code from my notebooks.
For visualisation, I have added abilities to show popup