chore: deny leaks, let fmt indent .rs files - #48
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 73.81% 73.81%
=======================================
Files 4 4
Lines 317 317
=======================================
Hits 234 234
Misses 83 83 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR tightens linting to prevent intentional memory leaks via Box::leak / Vec::leak, and adjusts repository-wide formatting policy via .editorconfig.
Changes:
- Forbid
clippy::disallowed_methodsand configure it to disallowBox::leak/Vec::leak(std + alloc). - Remove most indentation rules from
.editorconfig, leaving only YAML indentation configured.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
clippy.toml |
Adds a disallowed-methods list targeting Box::leak / Vec::leak. |
Cargo.toml |
Sets clippy::disallowed_methods lint level to forbid. |
.editorconfig |
Removes global/Markdown/license/lock indentation rules; keeps YAML at 2 spaces. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CommanderStorm
approved these changes
Jul 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- [ ] I added an entry toCHANGES.mdif knowledge of this change could be valuable to users.