Fix the layout for modal, dialog due to the change in MapViewerLayout#11956
Merged
allyoucanmap merged 4 commits intogeosolutions-it:masterfrom Feb 6, 2026
Merged
Conversation
8 tasks
allyoucanmap
requested changes
Feb 5, 2026
Contributor
There was a problem hiding this comment.
@subashtiwari1010 using Portal seems fine to solve this problem, I noticed also following problems:
- When opening a right panel such as Layer Catalog the footer is pushed down
- We need to add a z-index also minimum e.g. 10 to the mapstore-map-footer to hide the shadow coming from the above panels
- When opening the attribute table the first time the placeholder with the loading is not taking the correct space and there is a floating spinner
allyoucanmap
approved these changes
Feb 6, 2026
Contributor
|
@ElenaGallo please test in dev this additional tests, thanks |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the UI layout when the dialog, modal opens. It addresses the issue mentioned in #11789 (comment).
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
Some of the modal, dialog present in the body does not load properly as header and footer overlaps them.
#11794
What is the new behavior?
The modal, dialog are now wrapped with Portal so it does not clashes with the header and footer.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information