#12237: fix the background selector show an error in console#12242
Merged
Conversation
…onsole Description: - Refactored BackgroundSelector.jsx - Moved the logic for detecting and adding the missing Ellipsoid terrain from the main function body into a React.useEffect hook
1 task
MV88
requested changes
Apr 22, 2026
…seEffect in web/client/components/background/BackgroundSelector.jsx file
MV88
approved these changes
Apr 23, 2026
Member
|
Successfully created backport PR for |
offtherailz
added a commit
that referenced
this pull request
Apr 24, 2026
…#12297) * #12237: fix the background selector show an error in console Description: - Refactored BackgroundSelector.jsx - Moved the logic for detecting and adding the missing Ellipsoid terrain from the main function body into a React.useEffect hook * - resolve review comment of import useEffect instead of using React.useEffect in web/client/components/background/BackgroundSelector.jsx file (cherry picked from commit 32f9ee3) Co-authored-by: mahmoud adel <58145645+mahmoudadel54@users.noreply.github.com>
Brice150
pushed a commit
to Brice150/MapStore2
that referenced
this pull request
May 18, 2026
…onsole (geosolutions-it#12242) * geosolutions-it#12237: fix the background selector show an error in console Description: - Refactored BackgroundSelector.jsx - Moved the logic for detecting and adding the missing Ellipsoid terrain from the main function body into a React.useEffect hook * - resolve review comment of import useEffect instead of using React.useEffect in web/client/components/background/BackgroundSelector.jsx file
huntsmarinho
pushed a commit
to huntsmarinho/MapStore2
that referenced
this pull request
May 31, 2026
…onsole (geosolutions-it#12242) * geosolutions-it#12237: fix the background selector show an error in console Description: - Refactored BackgroundSelector.jsx - Moved the logic for detecting and adding the missing Ellipsoid terrain from the main function body into a React.useEffect hook * - resolve review comment of import useEffect instead of using React.useEffect in web/client/components/background/BackgroundSelector.jsx file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR includes resolving "Cannot update during an existing state transition" console error in BackgroundSelector. It includes:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#12237
What is the new behavior?
The console error of background selector has been gone, resolved by the fix.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information