WIP Fix #3360 - Build of binary

[offtherailz]

Description

The problem was caused by the usage of the mapstore folder in target directory of mapstore2-web instead of adding files to the war (the war plugins adds fixes to it, and these are not present in the folder).
To solve the issue I added a module bin-war that uses maven-war-plugin to add the needed files to mapstore2.war and then add it to the zip file.

I Added also profile parameter to the build script. This fixes also the bin package with doc (old bin package linked doc in the home page, but the link was dead because it was removed after build)

Maps not working

The new db attached to this PR has all maps working correctly:

• Some of the maps has layers that are not published on the web anymore. I removed these maps from db
• The other maps had a strange problem with bbox request to getMap (encoded 2 times) probably an old issue. I recreated the them and they work even in a clean build.

Issues

• Fix MapStore 2 Binary package do not work #3360

Please check if the PR fulfills these requirements

• The commit message follows our guidelines: https://github.com/geosolutions-it/MapStore2/blob/master/CONTRIBUTING.md
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x", remove the others)

• Bugfix

What is the current behavior? (You can also link to an open issue here)

• mvn clean install -Prelease profile was dependent by a previous execution of build.sh
• Bin package thumbnails was not working
• Bin package maps was not working
• Bin package didn't include the documentation and so page link in home page is broken

What is the new behavior?

• build script can be lunched with release argument to build also binary
• mvn clean install -Prelease can be lunched by its own
• Thumbnails are visible
• Maps are working correctly
• Bin contains documentation (linked)

Does this PR introduce a breaking change? (check one with "x", remove the other)

• Yes
• No

** Release should be lunched using ./build.sh <version> release (release profile) . This profile creates also the binary package, together with mapstore.war (all at once).

Other information:

shutdown script do not shutdown anything

This is a new problem, once try to execute mapstore2-shutdown.sh or .bat, the java process is still pending. This happens both on windows and linux. With windows you can close the java terminal manually, with linux you have to find and kill the process. @tdipisa should we open a different issue for this?

These are the notes about the previous implementation:

Old sequence on build server was:

./build.sh
mvn clean install -Drelease.number=DEV -Prelease

• build.sh create the mapstore dir and the war.
• mvn clean install.. copy mapstore dir in the release package.

The first build the web module, the second creates the zip.

The current solution uses the mapstore folder instead of the war to copy also the database present in release/data into the webapp root binary needs a pre-defined h2 db.

The problem with the thumbnails is because of duplicated jars for apache commons-codec.

These jars are excluded from mapstore.war using war plugin packageExclusions configuration, but not from the used mapstore folder.

[coveralls]

Coverage increased (+0.004%) to 80.771% when pulling 02a5f25 on offtherailz:fix_#3360 into cfd5f4e on geosolutions-it:master.