Check axis order in Layer.getEnvelope and GetMap.setBounds( Envelope ) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ayer, or when added using GetMapRequest. Refactor out a common method for toServerCRS for consistent handling
Member
Author
|
Rejected due to needless changes to gt-referencing - replaced by #40 |
sjudeng
added a commit
to sjudeng/geotools
that referenced
this pull request
Jan 13, 2020
Additional documentation on logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored out a toServerCRS method which takes server version into account when determining a CoordinateReferenceSystem object.
This method is now used by CRSEnvelope to ensure the CoordinateReferenceSystem in the data structure matches the server. Layer.getEnvelope will then use a transform to process the data into the Envelope the user expects (according the global forceXY setting).
On the other side of the coin the GetMap.setBounds(Envelope) transforms the provided Envelope and makes sure the GetMap request is filled in to correctly match the order the Server (not the local client) expects. I considered doing this as part of issuing the GetMapRequest - but then we would of had a data structure that did not represent what was being sent over.
Note the methods used by WMS cascade - setBounds( String ) and setSRS( String ) remain fire and forget and do not make any attempt at consistency.
For context of this issue see https://jira.codehaus.org/browse/GEOT-4283 WMS 1.3.0 GetMap Request